Skip to content

Akunkel/stroke fix#56546

Closed
andrewkunkel wants to merge 328 commits into
react:mainfrom
discord:akunkel/stroke-fix
Closed

Akunkel/stroke fix#56546
andrewkunkel wants to merge 328 commits into
react:mainfrom
discord:akunkel/stroke-fix

Conversation

@andrewkunkel

Copy link
Copy Markdown

Summary:

Changelog:

Test Plan:

react-native-bot and others added 30 commits September 9, 2025 16:43
#publish-packages-to-npm&0.81-stable
Changelog: [Internal]
#publish-packages-to-npm&0.81-stable
Changelog: [Internal]
…react#53503)

Summary:
Resolves react#53501

This is a pretty major oversight of (presumably) the old autolinking refactor. The iOS autolinking's second stage, invoked in `use_react_native!` does not accept the `react-native-config` sub-command's `react-native-config` output. This is only invoked and used in the prior step, `use_native_modules`.

The second step instead invokes old code that does something _similar_ to the new autolinking in `scripts/generate-artifacts-executor`, and happens to align in most cases. (But it does "autolinking" from scratch). tl;dr: When the results don't match up, things go wrong.

Instead, we now write the autolinking (react native config) results to a file, then read the output back in the second step.

This doesn't affect Android/Gradle, which are implemented correctly.

[IOS] [FIXED] - Use autolinking-generated react-native-config output in second step of cocoapods linking that generates artifacts and generated source

Pull Request resolved: react#53503

Test Plan:
- See react#53501 for failing repro
- Clone for working repro: https://github.com/byCedric/react-native-codegen-ios-autolinking/tree/fix-54503
  - Note: Contains this PR's changes as a patch
  - `bun install`
  - `bun expo run:ios`

Reviewed By: cortinico

Differential Revision: D81490755

Pulled By: cipolleschi

fbshipit-source-id: eefe786a116404f4ed24bd7125dfb108a811f71e
Summary:
Follow-up to react#53503 for a regression

When no React Native module is present this bail condition stops us from generating the artifacts podspec that's needed to complete build.

## Changelog:

[IOS] [FIXED] - Fix regression that skips artifacts code generation

Pull Request resolved: react#53690

Test Plan:
- Create an app **without** any React Native modules, run `pod install`; without this fix the podspec will be missing and the build will fail
  - With expo this can be reproduced using `create-expo-app --template blank-typescript@next` on `react-native@0.81.2`
  - With the community CLI this can be reproduced using `npx react-native-community/cli@latest init test --skip-install --version 0.81.2` and uninstalling `react-native-safe-area-context`

Reviewed By: javache

Differential Revision: D82103491

Pulled By: cipolleschi

fbshipit-source-id: 3d9619b5a935ca920220824b3963a9a107f926ca
#publish-packages-to-npm&0.81-stable
…chronously (#14)

* expose `flush` on RCTWebSocketModule to close all open websockets synchronously

add log statement back

* simplify code

* simplify even more

* change comment
For some reason the in-repo version isn't where this script it expects it to be (it's at `src` in our repo, whereas the script is looking in `lib`). This is likely due to us pulling down the source code directly whereas the script expects it to have gone through some build process first. In any case, this updates thes cript to prefer the version provided via NPM which does tend to work.
…cker.

Add ability to override mSource of the image source.
This fixes an issues where the fabric renderer would get the correct
sizing via onSizeChanged, write it to the shadow tree generating a state
update callback and then setting the wrong size using ModalHostManager.
Once onSizeChanged is fired by the OS it is treated as the definitive
source of truth for sizing.
Flewp and others added 26 commits March 26, 2026 20:18
[fix] set background correctly in setFeedbackUnderlay
onHostPause already checks activeActivities and skips pausing when
other activities are still active. onHostDestroy lacked this check,
so destroying a secondary activity while the primary was still alive
would move the shared ReactContext to BEFORE_CREATE. If the primary
was never paused, no subsequent onHostResume would fire, leaving the
context permanently destroyed and unresponsive to input.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…os-part

feat: implement ios part of measureOnUI
@meta-cla

meta-cla Bot commented Apr 21, 2026

Copy link
Copy Markdown

Hi @andrewkunkel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions

Copy link
Copy Markdown

Caution

Invalid Changelog Format

Please verify your Changelog format. See Changelog format

@github-actions

Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: BREAKING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.